◊(Local Yarn Code "Ticket Change Details")


Artifact ID: 614c1d5ec629cc933fec3aa89d8d8a9f1f0bf4db69f0b4852c85924168d269d5
Ticket: fbbb5ed93f0d7e1b0574a2f6bf81e3486f69089a
Macros in pollen.rkt are redundant
User & Date: joel on 2019-03-16 20:57:36

  1. icomment:
    Resolved in [6b60dc]. It turns out the macros are not redundant: one handles keyword arguments and one doesn’t. Maybe I knew this at one point and forgot. At any rate, the resolution was to change the names of the macros and change the way they are documented.
    I could have gone with a single function to handle all cases, but my thought was that perhaps I would benefit by not using <code>define-tag-function</code> in places where I didn’t need keyword arguments. I have not benchmarked this or anything, but <code>define-tag-function</code> is itself a macro that uses <code>make-keyword-procedure</code>, which seems needlessly complicated and, surely (?), slower than just <code>define</code>ing a simple function when keyword arguments are not needed.
  2. login: "joel"
  3. mimetype: "text/x-fossil-wiki"
  4. resolution changed to: "Fixed"
  5. status changed to: "Closed"