◊(Local Yarn Code "History Of Ticket fbbb5ed93f0d7e1b0574a2f6bf81e3486f69089a")

Artifacts Associated With Ticket fbbb5ed93f0d7e1b0574a2f6bf81e3486f69089a

  1. Ticket change [9a17f4a2] (rid 154) by joel on 2019-02-11 05:21:59:

    1. icomment:
      The macros poly-branch-tag and poly-branch-func are redundant. The second one does everything that is needed. The current poly-branch-tag should be eliminated, and poly-branch-func should be renamed to poly-branch-tag.
    2. login: "joel"
    3. mimetype: "text/x-fossil-plain"
    4. severity initialized to: "Cosmetic"
    5. status initialized to: "Open"
    6. title initialized to: "Macros in pollen.rkt are redundant"
    7. type initialized to: "Code Defect"
  2. Ticket change [90d4d71d] (rid 155) by joel on 2019-02-11 05:22:43:

    1. login: "joel"
    2. mimetype: "text/x-fossil-plain"
    3. priority changed to: "Medium"
    4. resolution changed to: "Open"
  3. Ticket change [614c1d5e] (rid 229) by joel on 2019-03-16 20:57:36:

    1. icomment:
      Resolved in [6b60dc]. It turns out the macros are not redundant: one handles keyword arguments and one doesn’t. Maybe I knew this at one point and forgot. At any rate, the resolution was to change the names of the macros and change the way they are documented.
      I could have gone with a single function to handle all cases, but my thought was that perhaps I would benefit by not using <code>define-tag-function</code> in places where I didn’t need keyword arguments. I have not benchmarked this or anything, but <code>define-tag-function</code> is itself a macro that uses <code>make-keyword-procedure</code>, which seems needlessly complicated and, surely (?), slower than just <code>define</code>ing a simple function when keyword arguments are not needed.
    2. login: "joel"
    3. mimetype: "text/x-fossil-wiki"
    4. resolution changed to: "Fixed"
    5. status changed to: "Closed"